Design comparison
Community feedback
- @Gato513Posted 3 months ago
Hi 👋 Great effort on your first challenge 👍
I have a suggestion for your code. You might consider using more semantic HTML tags to improve overall accessibility and help with SEO. For example, you could wrap your image in a
<picture>
tag and use an<article>
for the card instead of a<div>
. Additionally, it would be good to add analt
attribute to the QR code image to improve accessibility for users with screen readers. I also noticed that the@media query
in your CSS is incomplete; completing or removing it would be more favorable for keeping the code more optimal.I hope this is helpful 😀
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord