Skip to content
Submitted almost 3 years ago

QR Code Component Challenge using HTML and CSS

Nicolás Herrera•70
@herreranicolas
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is my first challenge.

What do you think I can do better?

Feel free to give me your feedback!

Thanks in advance!

Community feedback

  • Jessica•880
    @perezjprz19Posted almost 3 years ago

    I would just work on clearing your error report. You can make the bold text an h1 and wrap your container div in a <main> tag. That should resolve the issues.

    Other than that, just keep practicing until you can move on to building responsive layouts :-).

    FYI - The image is touching the sides of the container on my phone screen.

    Still a good job though 😀 Keep coding.

    Marked as helpful
    1
    Nicolás Herrera•70
    @herreranicolasPosted almost 3 years ago

    @perezjprz19 Haha poor image must be a little bit frezzing and wants a hug of the container ;) haha just kidding. Thanks a lot Jessica!! I really appreciate your feedback and I'll take it into account for my future solutions. I'll keep on practicing :D

    0
    Jessica•880
    @perezjprz19Posted almost 3 years ago

    @herreranicolas haha yeah it must be 😂 I don't think having such a rigid friend helps him feel warm and welcomed though.

    You're welcome!

    Marked as helpful
    0
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    Hey good job on this challenge! Your report above shows a few issues though:

    • wrap everything in your body in <main> ... OR use semantic tags! .... you can also give role="" to the direct children of your <body> but that's a little frowned upon... Read more here
    • have at least one <h1> in your code

    Here's my repo for future reference.

    Hope this helps :)

    Marked as helpful
    0
  • Jordan Phillips•425
    @JordanPhillips-hubPosted almost 3 years ago

    Try putting the blueish grey background colour on your body instead of the .container this should fill make the whole page that colour and get rid of the white patch at the bottom.. Looks good though.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord