QR code component challenge using CSS and HTML

Community feedback

• 

  HashimAlSadah•860

  @HashimAlSadahPosted over 2 years ago

  Hi @saksham747, congrats on completing this challenge, but I have few tips that will improve your solution.

  First, to answer your question the best way to add the space between the container <div class="box"> and the image is to use padding for the box container, which will result in equal space in all directions.

  I also noticed that you are using a lot of fixed heights and widths in you code, which makes you struggle with responsiveness and make you add unnecessary margins and padding.

  I have looked at your code and commented the unnecessary lines and add others instead. it is in the following codepen, please take a look at it.

  I also recommend the free course about responsive layouts by (Kevin Powell).

  You can also look at his channel on YouTube in following link.

  Overall, great job and Keep Coding

  Marked as helpful

  0

  ---

  

  Saksham Sandhu•10

  @saksham747Posted over 2 years ago

  @HashimAlSadah Thanks a lot, will certainly improve on this.

  0