QR code component challenge, used HTML5 with CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  #white-card {
    margin-top: 100px;
    margin-left: auto;
    margin-right: auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Shahzaman Abbasi•170

  @Shazee17Posted over 1 year ago

  Good job on the solution! I have one suggestion I'd like to give you, it looks like your component is not in the center of the page. For it to be in the center on every screen state, I'd recommend using these CSS properties on the body tag:

  body{
      display: flex;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
  }
  

  Have a nice day!

  0