Qr Code Component Challenge, used basic html and css

Community feedback

• 

  RabicaTahir•500

  @RabicaTahirPosted over 1 year ago

  Hello Karleen 👋. Congratulations on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️: Wrap the page's whole main content in the <main> tag. or use sections for dividing the content.It would be easier for you to find the main content in future.

  CSS 🎨:

  Instead of using pixels you should use **(%) ** and (vw) for setting width of the page and for centering content firstly use min-height property . I hope you find it useful! 😄

  Once again you did a good job.

  Happy coding!

  0

  ---

  

  LeeLee•30

  @karleenmsrichardsPosted over 1 year ago

  @RabicaTahir I love your feedback thank you. Please explain further if you can the use of percentages instead of pixels. Also can you describe the use of the min-height property for centering? Many thanks...

  0

  

  RabicaTahir•500

  @RabicaTahirPosted over 1 year ago

  @karleenmsrichards , Okkay so here it is.

  CSS🎨:

  -In using “height” in paddings or margins, you should use % instead of px, in case your website is responsive.

  also

  -The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size.

  -To center the content on the page, add eg:{min-height: 100vh} to the body for the 100% of the viewport height.

  I hope it clears now if not ask me anytime.

  Happy Coding & Stay Safe.🤞

  Marked as helpful

  0