QR Code Component Challenge Solution using HTML & CSS
Design comparison
Solution retrospective
Hi Frontend community members. This is my first challenge solution. Please have a look on the same and kindly suggest any improvement in the same.
Many thanks.
Community feedback
- @correlucasPosted about 2 years ago
👾Hi @vickschap, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
1.Use
<main>
instead of<div>
to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.2.Replace the
<p>
containing the main title with<h1>
note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.3.Use relative units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.4.
Keep the image responsive
. To manage the image size, you don’t need to define thewidth
andheight
together, if you do it with different values this will make the image lose proportions, to keep the image responsive and respect the container size useimg { display: block; max-width: 100%}
this way the image resize with the container whatever its size.Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
✌️ I hope this helps you and happy coding!
Marked as helpful2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord