Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr- Code- Component Challenge

P
Tuminhaโ€ข 60

@Tuminha

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It was easy. Nice beginning. I think I did it correctly.

Community feedback

Bryan Liโ€ข 3,530

@Zy8712

Posted

Congrats on completing your first challenge!

Some things that I noticed when looking through your code:

  • you are missing closing tags for your <html> tag and <body> tag
  • you should include a <main> tag around your main page content, this is for accessbility purposes
  • with your header tag you should start with <h1> not <h3> Header tags are meant to be used in descending order, so you should skip any. All headers have a default font size which can be changed in css using the font-size property

Hope you find this feedback useful ๐Ÿ‘

0

@MelvinAguilar

Posted

Hello there ๐Ÿ‘‹. Good job on completing the challenge !

  • Your design looks great! Just a small suggestion: consider using min-height: 100vh instead of height: 100vh for the body element. min-height: 100vh allows the body to grow dynamically, preventing it from staying static. The issue I noticed on my computer is that your component gets cut off. You might also want to test it on your mobile device in landscape mode to see this problem

I hope you find it useful! ๐Ÿ˜„

Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord