Skip to content
Submitted 8 months ago

QR Code Component Challenge

adaviladevā€¢50
@adaviladev
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud of what I've achieved because it looks very close to the original. Still need to make improvements though!

What challenges did you encounter, and how did you overcome them?

This is the first time I upload a live site and I had issues organizing the files in github. I did't put the site in a dedicated folder at first.

What specific areas of your project would you like help with?

How to organize files in my github repository.

Do I have to use one repository per page?

Community feedback

  • Daniel šŸ›øā€¢44,310
    @danielmrz-devPosted 8 months ago

    Hello, @Adavilatr!

    Your project is looking fantastic!

    I'd like to suggest a way to make it even better:

    • Using margin isn't always the most effective method for centering an element.

    Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:

    šŸ“Œ Apply this CSS to the body (avoid using position or margins in order to work correctly):

    body {
    min-height: 100vh;
    display: flex; 
    justify-content: center;
    align-items: center;
}

    And yes, you need to use one repository per project!

    I hope you find this helpful!

    Keep up the excellent work!

    1
    adaviladevā€¢50
    @adaviladevPosted 8 months ago

    Hello, @danielmrz-dev!

    I really appreciate your feedback. This is my first upload and the first time I've received feedback for something I've made.

    I will definitely take your comments as a guide for my future projects!

    Currently, I have 1 repository, and I organize my challenges in different folders. You can see it here: https://github.com/adaviladev/adaviladev.github.io

    Is this not an okay approach? What is the difference between different repositories for each challenge and one repository for several projects organized in folders?

    Thank you!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord