QR code component challenge on Frontend Mentor

Community feedback

• 

  Danilo Blas•6,300

  @Sdann26Posted over 2 years ago

  Hi Demand_dev!

  Congratulations on finishing your first challenge!

  You have a few problems in your report which are:

  • Page should contain a level-one heading: This problem is generated because you have not placed an h1 which is necessary to have 1 per page. To solve it you can change the h4 of your project for an h1 (Keep in mind that if you make this change you must change the styles added to the new tag.
  • All page content should be contained by landmarks: To eliminate this problem you must add <div class="attribution"> inside the main or you must change <div class="attribution"> to <footer class="attribution"> so that the information inside this tag is contained in a landmark. I recommend the second option so that you don't modify your code too much.

  By the way the title should have the following color color: rgb(31, 50, 81) to be like the design.

  With all this you can eliminate the errors of the report and generate a new one without any error and also changing the color of the title would be more similar to the final design.

  I hope my comments are helpful, good coding!

  Marked as helpful

  1
• 

  Demand_dev•650

  @DemandtechPosted over 2 years ago

  Okay thank you so much for your feedback, and I will make the correction asap, I’m currently working on the second challenge and I will make use on this corrections… thank you once again I’m happy I got a response…

  0