QR Code component challenge

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Instead of using the <div> tag to wrap the text, try using the <p> tag. The <p> tag represents paragraph-level content, usually text, and is more semantically appropriate for this purpose. e.g.: <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>.

  • Wrap the page's whole main content in the <main> tag.

  CSS 🎨:

  • Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this lectures:

    • 1. Should I change the default HTML font-size to 62.5%?.
    • 2. The Surprising Truth About Pixels and Accessibility - The 62.5% trick.
    • 3. A comment on the 62.5% trick.

    Credit to grace-snow and vanzasetia.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  3