Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component Challenge

@Fatima-hub333

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi everyone, kindly check my solution. Are the best practices (DRY) I followed in the solution or not? & any other suggestions plz?

Community feedback

Mohamed 270

@mohamed-benoughidene

Posted

Hi @Fatima-hub333 ✌ great job completing this challenge it looks that you didn't follow best practices in your html witch is not using a level-one heading

it's best practice to start your component with h1 because Screen reader users can use keyboard shortcuts to navigate directly to the first h1. in this challenge It wouldn't matter a lot but when you work on a bigger project it's gonna make a bigger impact on the usability of your website, so you can just change h3 tag in line 17 to an h1.

finally, I hope you find my feedback helpful if so please upvote me and mark it as helpful 😃.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord