QR code component challenge hub

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Mustafa, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • add descriptive text in the alt attribute of the image
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • remove all margin from .containter class because with flex they are superfluous
  • use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here
  • remove <span class="sp" style="display: block;"> from p

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  Mustafa•100

  @MostafaKh1Posted over 2 years ago

  @denielden Thank you

  1