QR code component challenge hub

Community feedback

• 

  Muh Suryadi Triputra Rahman•400

  @msuryaditriputraRPosted over 2 years ago

  Hi Julieta Perez 👋

  Firstly, I wanna congrats you on your success finish this challenge 🎉

  However i have some feedbacks for u 🌼

  Accessibility 👀

  • Wrap all of your content with the main tag. All page content should be contained by landmarks.
  • For heading text use h1 instead of h3 if you just have one heading on your page. Page should contain a level-one heading.
  • Wrap attribution div with footer and place it at the bottom of your page for a better experience, or if you want to keep it at the top wrap it with header.

  Code & Design 🛠

  • If you want to place your div at the center of the page with position property. You should use transform: translateX(-50%) when you set the left with 50% and transform: translateY(-50%) when you set the top with 50%. or you just need to use transform: translate(-50%,-50%) for shorthand. learn more about translate
  • For best practice and easy way to make content centered is use grid layouting ⚡

  main{
      display: grid;
      place-content: center;
      min-height: 100vh;
  }
  

  and trada it's magic ☃ . learn more about grid layouting.

  I hope this helps, keep it up your good work and Happy Coding ☕

  Marked as helpful

  0
• 

  Liam•30

  @bvrklPosted over 2 years ago

  Get familiar with flex box in CSS.

  It helps with centering, but has a lot of other functionality to make your sites much more responsive to the screen sizes etc.

  0