QR code component challenge hub

Community feedback

• 

  codewithxavi•210

  @codewithxaviPosted almost 3 years ago

  Hey, I'm going to give you feedback. I know that this is your first challenge, I am not a professor but I can tell you some advice. I am watching your HTML and it has some errors, you can check that URL that is going to validate your HTML, https://validator.w3.org/nu/ (there is another website that can validate your CSS also). I can notice that you positioned the elements on the page but in an incorrect way, the things are not centered at all because you use a lot of margins and paddings. Margins and paddings are good but in a reasonable way, I recommend you to learn about flexbox and grid in the near future. Things will be easiest and also know the position of the elements of the HTML. If you have a div, an article, a section, a heading know if it is a display: block, display: inline-block, etc. You need to write the CSS in a more ordered way because if someone needs to write in your code to make it easier to understand, you don't write code to yourself only. Use an editor that helps you like Visual Studio Code. I know that this is a little bit extense, but this is my advice. Also, your code doesn't work well in mobiles, so you must work on the responsive a lot more. Thanks, and keep going on your challenges

  Marked as helpful

  0

  ---

  

  terrenoscu•30

  @terrenoscuPosted almost 3 years ago

  @xavi-coder Thanks for the feedback! I appreciated you taking your time to check my code. I'll try to improve it!

  0
• 

  MarijnPns•0

  @MarijnPnsPosted almost 3 years ago

  Hi bro, nice creation! However, I do wanna point out that your design (#mainlayout) isn't responsive mostly because of the css styling you use (positions, display, pixels etc.). Try to learn more relative css styling (flexbox, grids, %, rem etc.)!

  0