QR code component challenge

Community feedback

• 

  Youssef Waleed•200

  @ywsolimanPosted about 2 years ago

  Hi Vishal, I hope you're doing great! I am a newbie but I have some notes if you don't mind

  1. You should use HTML Semantic Elements instead of div as it doesn't have a real meaning <div class="rec"> should be <main class="rec"> because it's the main content of the page.
  2. From a semantic point of view, using an h3 without an h2 or h1 is not good practice. And therefore,

  <h3 class="heading">Improve your front-end skills by building projects</h3>

  should be

  <h1 class="heading">Improve your front-end skills by building projects</h1>

  and change the font-size if you're not happy with it.

  Keep up the good work!

  Marked as helpful

  0

  ---

  

  Vishal Mishra•60

  @happyvisuPosted about 2 years ago

  @ywsoliman Thanks for Suggestion. I am also a newbie.

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @happyvisu, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • You've done the design for the wrong image, when you download the starter files the folder comes with 3 files (preview card, desktop and mobile) you've created the solution based on the preview and you should consider only the mobile + desktop images.Remove the background-color from the container and add it to the body to make sure this color background will display it full screen.
  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  0