Design comparison
SolutionDesign
Solution retrospective
What can i improve in my code for this challenge?
Community feedback
- @ClaudioAmarenoPosted 12 months ago
Hello Alexandre! Your solution looks pretty cool. I have some tips for you if you want to improve it.
- You can use it to center your card: body{ display: flex justify-content: center align-items: center min-height: 100vh }
- Using <br> tag in HTML, it's not a good practice. Try using margin-left, margin-right for it.
- You should add class to your <p> and <h2>, and using it in CSS instead p, or h2
Have a nice day and happy coding!
1@AlmoptPosted 12 months ago@ClaudioAmareno
Hi Claudio,
I haven't learned the display property yet. I will take a look into the margin-left and right to replace the <br> tag.
Thanks for the feedback.
1 - @danielmrz-devPosted 12 months ago
Olá, Alexandre!
Você pode adicionar uma
box-shadow
ao seu card.Fora isso, está muito bom!
0@AlmoptPosted 12 months agoOlá @danielmrz-dev
Vou adicionar para ver como fica!
Obrigado pela dica!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord