Skip to content
Submitted about 2 years ago

QR code component challenge. Built with sematic HTML, flexbox layout

Funsho Ayobanjo•150
@ayobanjo
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Any corrections will be appreciated

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hello @ayobanjo, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:

    The main heading has the tag <h3>, in this case, you should replace it with <h1> since this heading is the main title on this page. Remember that every page should have one <h1> to declare which is the most important title and that you should follow the hierarchy using the heading sequence (h1, h2, h3, h4, h5) and never jump a level.

    Something I've noticed in your code is that on many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, which can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but all sizes as well.

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Funsho Ayobanjo•150
    @ayobanjoPosted about 2 years ago

    @correlucas Thank you very much. I will make neccessary corrections

    0
  • Aecio Neto•340
    @aecio-netoPosted about 2 years ago

    Hi Funsho, congratulations on finishing the project.

    Here are some considerations:

    Semantic HTML - you can remove or replace some divs and use <main> and <article> tags instead. It is also possible to use an h1 in place of the h3, as it is the main title of the page.

    The CSS looks pretty good to me.

    See ya

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord