Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component Challenge

mcodes97 40

@mcodes97

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


•Did I over do it with my CSS?

•Was it the best method to use position absolute and relative for everything?

This was my first solo project with only a few google references, how did I do? I know it's not perfect, what could I improve on next time when working with positioning and inline-blocks? I started with flexbox but I could not make that work.

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or absolute.
  • We don't need to use margin and absolute to center the component both horizontally & vertically. Because using margin or absolute will not dynamical centers our component at all states
  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.
  • For this demonstration we use css Grid to center the component.
body {
min-height: 100vh;
display: grid;
place-items: center;
}
  • Now remove these styles, after removing you can able to see the changes
.parent {
position: relative;
top: 0;
left: 0;
margin: 100px auto;
}
.white {
position: relative;
top: 0;
left: 0;
position: relative;
margin: 0 auto;
}
.blue {
position: absolute;
top: 20px;
left: 30px;
right: 30px;
margin: 0 auto;
}
.qr {
position: absolute;
top: 35px;
left: 30px;
right: 30px;
margin: 0 auto;
}
.parent-1 {
position: absolute;
top: 250px;
left: 30px;
right: 30px;
margin: 100px auto;
}
  • Now your component has been properly centered

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

1

mcodes97 40

@mcodes97

Posted

Sorry for such a late response.@0xAbdulKhalid

I was having lots of trouble trying to align everything. I am still new to this. I'm not too familiar with vh so I will have to practice more but I greatly appreciate this solution! :)

0

@0xabdulkhaliq

Posted

@mcodes97 Glad you found it helpful ! 🤠

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord