QR Code Component Challenge

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or absolute.

  ---

  • We don't need to use margin and absolute to center the component both horizontally & vertically. Because using margin or absolute will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .parent {
  position: relative;
  top: 0;
  left: 0;
  margin: 100px auto;
  }
  .white {
  position: relative;
  top: 0;
  left: 0;
  position: relative;
  margin: 0 auto;
  }
  .blue {
  position: absolute;
  top: 20px;
  left: 30px;
  right: 30px;
  margin: 0 auto;
  }
  .qr {
  position: absolute;
  top: 35px;
  left: 30px;
  right: 30px;
  margin: 0 auto;
  }
  .parent-1 {
  position: absolute;
  top: 250px;
  left: 30px;
  right: 30px;
  margin: 100px auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  mcodes97•40

  @mcodes97Posted over 1 year ago

  Sorry for such a late response.@0xAbdulKhalid

  I was having lots of trouble trying to align everything. I am still new to this. I'm not too familiar with vh so I will have to practice more but I greatly appreciate this solution! :)

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @mcodes97 Glad you found it helpful ! 🤠

  0