@sophiakoulen
Posted
Hi!
Your solution looks good. Here are my thoughts on your code:
I wouldn't personnaly use the <br> tag to force line breaks since you might want your component to adapt to multiple screen sizes.
I found that putting most of your code in a media query makes it less readable. I'd put only the things that change inside a media query and avoid them if i can find another solution. (For example, using vw
as a unit, using the modern clamp()
, min()
, max()
to adapt widths or font-sizes.)
I'm curious as to why you chose display:inline-block;
.
A quick fix for the vertical centering is to have a height:100vh
on your .screen
, and either use
display:flex;
align-items:center;
justify-content:center;
Or
display:grid;
place-items:center;
Hope this helps!
Marked as helpful