QR code component challenge

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Great job with this project. Looking at your solution, it's decent and I would suggest the following for you...

  • Clean the whitespaces in your code
  • Wrap the container with specific tag like main for readability
  • Uncomment the attribution section and wrap it with footer , put your name and add links to your work/portfolio and add padding
  • Add margin: 1rem 0; to the rule set of h1 to have enough spaces within the card

  Overall you did well and Keep up the good work!

  1

  ---

  

  selehadin cyber•90

  @selehadin-cyberPosted almost 3 years ago

  @RioCantre thanks a lot ! i have implemented your suggestions and pushed them to my repository. but it doesn't seem to update my changes in the design comparison

  1

  

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  @selehadin-cyber Awesome! You need to click the "Generate Screenshot" to update the screenshot.

  I would appreciate it if you mark this as helpful.

  Marked as helpful

  1