QR Code Component with Simple HTML and CSS

Community feedback

• 

  Clément Creusat•1,655

  @ccreusatPosted almost 3 years ago

  Great job !! It's perfect and no report issues ;)

  The only thing I would suggest is if you use BEM approach, change :

  • main__card-heading > main-card__heading

  Usually, its :

  • .parent
  • .parent__children
  • .parent__children--modifier

  :)

  Marked as helpful

  0

  ---

  

  Hania B.•1,320

  @techantherePosted almost 3 years ago

  @ccreusat thanks for the suggestions, really appreciated! I didn't really start taking bem naming convention serious until now, but I think I should definitely consider it.

  1

  

  Clément Creusat•1,655

  @ccreusatPosted almost 3 years ago

  @techanthere now you can :) nice job tho!

  1
• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted almost 3 years ago

  I really thinks its the margin top u added to the footer text that's why there is a slight deference between design and code....it also happened me...but actually I don't think it makes a difference... Good job there :)

  1

  ---

  

  Hania B.•1,320

  @techantherePosted almost 3 years ago

  @Kamasah-Dickson good job with that, feedback much appreciated!

  1