QR Code Component Challenge

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job Udoh

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container. For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc . But use header tag only once in main heading element.

  Keep up the good work!

  Marked as helpful

  0

  ---

  

  Udoh Julie•200

  @Jey223Posted almost 3 years ago

  @Crazimonk Thank you so much. Does that mean the heading tag can't be used outside a header? Since I don't have an available header tag.

  1

  

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  @Jey223 No you can use bt.. for semantic tags it is imp

  Marked as helpful

  0
• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Good work with this project. Looking at your solution, I would suggest the following for you...

  • In the body rule set, remove all except for background-color: hsl(212, 45%, 89%);
  • Remove position: relative;, top: 100px; and bottom: 100px; in section and add margin: auto; and margin-top: 9rem;
  • Remove position: relative; in section > img, section > h2, and section > p. By removing the position, it will have a responsive design.
  • Wrap the whole content with main tag instead of section

  Hope this helps and Keep it going!

  Marked as helpful

  0

  ---

  

  Udoh Julie•200

  @Jey223Posted almost 3 years ago

  @RioCantre Thank you so much. This makes my CSS shorter too.

  1

  

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  @Jey223 No worries! Glad I could help. Cheers!

  0