Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr code component challange

@mustafa-tufekci

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any advice are welcome

Community feedback

Lucas 👾 104,400

@correlucas

Posted

👾Hello again Mustafa , congratulations for your new solution!

This is a great solution, you dont need to fix many stuff, is almost perfect.

To improve a bit the container you can add a margin of 20px to create a gap between the component and the screen edges. Also remove the div holding the content an use <main> to improve the semantics.

.container {
    margin: 20px;
    max-width: 360px;
}

You also don't need some many block of divs, all you need is a single <main> or <div> to keep all the content inside, and nothing more. The ideal structure is the div and only the image, heading and paragraph.

👋 I hope this helps you and happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord