Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code component HTML/CSS

Lucas 50

@Lucas-allard

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@malek-bt

Posted

Hey !, how are you ? I really liked the result of your project, but I have some tips that I think you will enjoy:

*Remove the 2 lines after </html> and Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information. Once you update the container <div class="attribution">, the footer should be outside the main content.

*Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers.

*The color of <h3> should be color: hsl(218, 44%, 22%);

*Inverse the color of background and the paragraph.

*I see your README file is MAL structured. README is a very important aspect of making projects, especially if you want other people to see it. You should read the README file and the README-template file to make nice one.

The rest is good, I hope those tips will help you! 👍

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord