QR code component card

Community feedback

• 

  Brendan•1,120

  @OneManBannedPosted about 1 year ago

  Hi Rabel, I have a few suggestions for you.

  • The <h3> tag should be a <h1>. Every page needs a <h1> and the heading elements (<h1><h2><h3><h4><h5><h6>) must be used in ascending order. Here is the mdn page on heading elements

  CSS

  • If you remove the margin declarations from .card and the width from main. Then add the following to main

  justify-content: center;
  min-height: 100vh
  

  you will have it all nicely centered using flex-box :)

  • I suggest you look at using relative units instead of pixels. Have a look a rem, em, vh, vw and %. Here is a handy page that converts pixel vales into rem (link)

  Nice solution. Happy Coding

  Brendan.

  Marked as helpful

  0