Skip to content
Submitted about 2 years ago

QR Code Component Card

Edmond Wu•40
@Edmond-Wu-9
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey @Edmond-Wu-9, some suggestions to improve you code:

    • To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):
     <body>
      <main>
        <article class="card-container"></article>
      </main>
      <footer class="attribution"></footer>
  </body>

    The Main Element identifies the main content of the document.

    While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.

    More info:

    https://web.dev/learn/html/headings-and-sections/

    • The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

    • Add a ** max-width: 320px;** to your container to give it the correct width and make it responsive.

    • For your image delete the height and change the width to 100%.

    • There is no need for a media query for this component.

    Happy Coding! 👻🎃

    1
    Edmond Wu•40
    @Edmond-Wu-9Posted about 2 years ago

    @vcarames Thank you very much for the feedback! I did all your adjustments that would be structured better

    0
    バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    @Edmond-Wu-9

    Looks good! Keep it up!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord