Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

pmigix 110

@pmigix

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Challenge #1 completed, tho I suspect there might be some responsive issues regarding height. Open to any tips.

Community feedback

P
gfunk77 1,200

@gfunk77

Posted

Nice job on the QR code. I’d suggest a few things:

  • use min-height: 100vh on your container. This will keep you card from cutting off on small screens.
  • try putting your image at max-width: 100%
  • on desc try using text-align: center to center the text instead of margins.

I hope this is helpful or at least goffers some stuff to try out. Your solutions looks great. Congratulations

Marked as helpful

1

pmigix 110

@pmigix

Posted

Thank you, @gfunk77! I've taken your suggestions into consideration and implemented some changes.

0
Aliya 40

@SkAliya

Posted

@pmigix hey hi, can you tell me how u inserted screenshot in readme.md file! thanks in advance😊

0
pmigix 110

@pmigix

Posted

@SkAliya ![alt text](image.jpg)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord