
Design comparison
Community feedback
- @spalquiPosted 7 days ago
Great use of semantic HTML tags such as
main
andsection
. It shows that you thought about the most descriptive tag for your content. Your images also contain alt attributes which also shows you took accessibility into account.Your solution is responsive and follows the designs very closely so great work!
You could improve your CSS code by using CSS variables to store shared values such as the theme colours. I also like the use of a reset ruleset at the start to ensure consistency.
Overall, this was a great solution! Keep up the good work.
Marked as helpful0P@IbrahimAyed1Posted 7 days ago@spalqui Thanks Daniel, for your review. I appreciate it and appreciate taking the time to review the code.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord