QR Code static page using CSS Grid

Community feedback

• 

  Maciej Narejko•180

  @MaciejNarejkoPosted almost 2 years ago

  Hi there 👋

  Well done for completing this challenge!

  Your solution is pretty good, however I have a few suggestions:

  • to fix accessibility issue wrap <div class="attribution"> in a footer tag.
  • it would be nicer and more semantically replacing header <p> width <h1>
  • attribute width on .container Your solution works well if user has browser window size 1440px or 375px but in other cases, the website displays incorrectly. I would remove

  @media screen and (max-width: 375px) {
      .container {
          width: var(--mobile);
      }
  } 
  

  and width: var(--desktop); from .container to achieve the fastest satisfactory effect.

  You can read more about RWD, of course, if you need e.g. here. These are minor details so don't worry.

  Happy Coding!

  Marked as helpful

  0