QR code component by Benjamin

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Benjamin, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1
• 

  Darynka Tapia•90

  @Darynka-TapiaPosted about 2 years ago

  Hello @BennyBenV, it's great that you completed your first challenge ✨

  Here are a few recommendations to get your element centered on the screen:

  • You can remove the margin percentage and leave it as margin:0 auto;
  • Add Viewport units to the body: width: 100vw; height: 100vh;
  • Add flex or grid to move around the layout: justify-content, align-items

  https://css-tricks.com/snippets/css/a-guide-to-flexbox/ https://css-tricks.com/snippets/css/complete-guide-grid/

  Here's my solution for this challenge if you wants to see it. ✌ https://www.frontendmentor.io/solutions/qr-code-component-aFQhD4VF3U

  Marked as helpful

  1

  ---

  

  Benjamin•120

  @BennyBenVPosted about 2 years ago

  @Darynka-Tapia Hi ! Thanks for the feedback. I'm not familiar yet with the flex and the grid. I'll keep learning !

  0