QR Code Component 🎯 [ SEMANTIC MARKUP + VANILLA CSS + BEM ]

Community feedback

• 

  Mamadou Mar•550

  @Mar1362Posted about 2 years ago

  hi, hope you are doing well! I really appreciate the way you did the challenge as well in the design than the way you coded it. I found it clear but i think that in your html code you may use <main> tag instead of <div class="container"> and i don't understant why you put 120vw for your background-size and 880% at the media one. Good continuation!

  Marked as helpful

  2

  ---

  

  Abdul Khaliq 🚀•72,480

  @0xabdulkhaliqPosted about 2 years ago

  @Mar1362

  REPLY:

  • Thanks for leaving a comment which helps to improve my code, I' fixed the issue.
  • Now check the project once again to explore the difference between old one.

  0

  

  Mamadou Mar•550

  @Mar1362Posted about 2 years ago

  @0xAbdulKhalid yes i saw the code and it looks clean for me but still something in the html one, instead of doing this:

  <div class="container" role="main">
           ...
  </div>
  

  you may do the following:

  <main>
     ...
  </main>
  

  i didn't know about the difference since the visual result is the same and i did the same in my older codes but it is highly recommended to get the habbit of trying to use the right html segmentation in order to be comfortable with in more serious project later. I think you do not need to change anything in your html right now since it will may cause some changes in your css too (and i am really lazy :)) but you have better consider them in your next projects. checkout this link

  Marked as helpful

  1

  

  Abdul Khaliq 🚀•72,480

  @0xabdulkhaliqPosted about 2 years ago

  @Mar1362 Sure brother hereafter i will try to use semantic tags..:-)

  1

  

  João Marcos Donizetti Rodrigues•30

  @jmdonizettiPosted about 2 years ago

  @0xAbdulKhalid Ficou muito bom, fundo ficou perfeito parabens

  2

  

  Abdul Khaliq 🚀•72,480

  @0xabdulkhaliqPosted about 2 years ago

  @jmdonizetti

  • commenting in english will help every people to understand brother
  • Nice to hear your feedback, Thanks brother..

  0
• 

  Dumte Nwidoobee Joshua•100

  @DumtePosted over 1 year ago

  Please take a look at my solution. I want you to suggest to me how to improve on it.

  1

  ---

  

  Abdul Khaliq 🚀•72,480

  @0xabdulkhaliqPosted over 1 year ago

  Thanks for reaching out @Dumte, I'll take my time to review the code and will try to give valuable feedback.

  1
• 

  ASEM-TOP•20

  @ASEM-TOPPosted about 2 years ago

  Abdul Khalid... you are awesome.!.!.!.!.!.!.!.!.!.!.!.!.!.

  1

  ---

  

  Abdul Khaliq 🚀•72,480

  @0xabdulkhaliqPosted about 2 years ago

  @ASEM-TOP, Thanks a lot for your appreciation dude,

  0

  

  Ava Christine•20

  @avaChristinePosted about 2 years ago

  @ASEM-TOP i'm just wondered by looking his solutions by visiting his profile they all are awesome

  0