QR code component build for desktop and mobile

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  In order to fix the accessibility issues:

  • You need to replace <div class="container"> with the <main class="container"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you should use one <h1> element in the <main> tag. You can replace your <p class="main-text">Improve your front-end skills by building projects</p> element with the <h1 class="main-text">Improve your front-end skills by building projects</h1> element.

  After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

  Hope I am helpful. :)

  Marked as helpful

  0

  ---

  

  Danielle Aranda•20

  @DLMedeiroPosted over 1 year ago

  Thank you @ecemgo! Definitely seeing I've picked up some bad habits, looking forward to more practice. :-)

  0

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @DLMedeiro No, please don't think like that. We are here to practice and improve our front-end skills. We are getting better by learning from our mistakes in time. Keep learning and coding :)

  0