Design comparison
Solution retrospective
I dont have any specific questions for this challanege however any general feedback or errors Ive missed would be appreciated. Thank you!
Community feedback
- @mohdahsanrazakhanPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge!
I have recommendations regarding your code that I believe it will great interest to you.
HTML: This solution generates accessibility error reports. So fix it by replacing the
<div id="mainContainer">
element with the semantic element<main>
in your index.html file to improve accessibility and organization of your page.Replace
h2
tag toh1
tag inside yourmain
tag and addalt="QR code image"
attribute inside<img src="images/image-qr-code.png">
In place of
<div class="attribution">
you should usefooter
tag.I hope you find this helpful.
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord