Design comparison
SolutionDesign
Solution retrospective
Give me your feedback!
Community feedback
- @PhoenixDev22Posted over 2 years ago
Hello Goorezy,
Congratulation on completing this challenge. Excellent work! I have some suggestions regarding your solution if you don’t mind:
- You can use
<main>
landmark to wrap the card. HTML5 landmark elements are used to improve navigation.
- In my opinion, the alternate text should indicate where the Qr code navigate the user : like
QR code to frontend mentor.
(not describes the image).
- Consider using
min-height: 100vh
instead ofheight: 100vh
to the body , that let the body grows taller if the content of the page outgrows the visible page
width: 400px;
an explicit width is not a good way. consider usingmax-width
to the card inrem
instead.
- Consider using
rem
for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
- Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.
Aside these, Good work! Hopefully this feedback helps
Marked as helpful1 - You can use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord