QR code component ( bigger on purpose )

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Goorezy,

  Congratulation on completing this challenge. Excellent work! I have some suggestions regarding your solution if you don’t mind:

  • You can use <main> landmark to wrap the card. HTML5 landmark elements are used to improve navigation.

  • In my opinion, the alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor. (not describes the image).

  • Consider using min-height: 100vh instead of height: 100vh to the body , that let the body grows taller if the content of the page outgrows the visible page

  • width: 400px;an explicit width is not a good way. consider using max-width to the card inrem instead.

  • Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  • Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.

  Aside these, Good work! Hopefully this feedback helps

  Marked as helpful

  1