@denielden
Posted
Hi Tonsz, great work on this challenge!
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility img
element must have analt
attribute, it's very important!- remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - remove
margin and transform
properties from.main
class - use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
try to use relative units of measurement -> read here
Overall you did well š
Hope this help and happy coding!
Marked as helpful
@tonsz
Posted
@denielden i am still learning to understand the difference between height and min-height, and surely i will get into practicing with flexbox so thank you for the guide! will try to do better thank u sm for the tips!