QR Code Component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="qr-container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  ya-hs•40

  @ya-hsPosted over 1 year ago

  @0xAbdulKhalid Hi Abdul, thanks for the feedback!

  Quick question about using landmarks - would it be fine to replace the <div class="qr-container"> element with <main> landmark element whilst keeping the <header> element inside it?

  Or are you better to leave landmark elements un-nested? Would it make more sense to replace <header> with <div class="header">?

  Thanks, ya-hs

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Thanks for rising an important question @ya-hs

  • Actually components don't need header we can just use main instead with proper heading structure that's all we need to do to make component like these as accessible

  ---

  • So you can change the header to div class=header or whatever according to your personal preference

  ---

  • But you want you use individual header element when it comes to landing page or intro sections

  ---

  • We don't need to add header for components, we can make our code more reusable if we follow simple semantics

  ---

  .

  Hope this suggestion is helpful to you !

  Marked as helpful

  1

  

  ya-hs•40

  @ya-hsPosted over 1 year ago

  Great, thank you so much @0xAbdulKhalid!

  0
• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • Replace min-height:100% with min-height:100vh in the body to properly center the card.

  • Use Semantics for the proper design of your code.

  <main>...</main>
  wrap up `.qr-container` div inside your main.
  <footer>...</footer>
  
  

  • For non-decorative images give meaningful and descriptive alt like alt= "QR code to frontend mentor website".

  • Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

  • Replace width with max-width to make your card more responsive.

  link.

  I hope you find this helpful.

  Happy coding😄

  Marked as helpful

  1

  ---

  

  ya-hs•40

  @ya-hsPosted over 1 year ago

  @NehalSahu8055

  Hi Nehal,

  Thanks so much for your feedback - I hadn't even considered the alt text for the image. Need to make sure I remember to keep accessibility in mind - it's too easy to get carried away in trying to make it look pretty.

  Thanks, ya-hs

  1