QR code component - Basic Html and Css

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Chicaofmp, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • remove all margin from .container1 class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well 😁 Hope this help!

  1

  ---

  

  Chicaofmp•30

  @chicaofmpPosted over 2 years ago

  @denielden

  Thanks for the tips!

  I will make the challenge once more to improve these issues! And im studying more about css grid ans flexbox to avoid these kind of problems ;)

  1
• 

  Karlisha•170

  @al-lattePosted over 2 years ago

  Hey 👋🏽 I just looked at your solution, nice work 👍

  I think when you zoom in and out it could be possible that you're changing the viewport height, so the scrolling appears. To me it's not necessarily a problem.

  0

  ---

  

  Chicaofmp•30

  @chicaofmpPosted over 2 years ago

  @al-latte

  Hey! thanks for the answer!

  I just saw that my card is flying comparing to the Real one. I need to fix this next time.

  Thanks!

  0