QR Code Component

Community feedback

• 

  trayansh005•50

  @trayansh005Posted 2 months ago

  Overall your solution is good but you can improve it by adding drop-shadow to your card and main tag to wrap your container

  Marked as helpful

  1
• 

  P

  Teodor Jenkler•3,740

  @TedJenklerPosted 2 months ago

  Hi @iyedoo,

  Nice project! I have a couple of suggestions for improvement:

  Semantic HTML: Consider using semantic HTML elements like <main>, <section>, or <article> to replace unnecessary <div>s (such as adding a <main> in this project). A good rule of thumb is to avoid <div>s as much as possible and use appropriate HTML tags. This will improve accessibility and lead to cleaner, more maintainable code.

  Headings Usage: You should only use <h1>, <h2>, and other heading tags based on the importance of the content, not for styling purposes. The <h1> tag is typically reserved for the page title and should only be used once on a page (and isn’t needed in this project).

  Keep up the great work!

  Best, Teodor

  Marked as helpful

  0
• 

  P

  Steven Stroud•11,890

  @StroudyPosted 2 months ago

  Great solution, Looks like you have done a fantastic job! A few things I noticed,

  • Missing a <meta> description tag for SEO purposes,
  • It is best practice to have a <main> tag inside your body highlighting the main section.
  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • Another great resource for px to rem converter.

  I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  Marked as helpful

  0