Qr code component attempt using HTML and CSS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 1 year ago

  Hi! 👋

  You should rename the indexQR.html to index.html. Otherwise, it will show the README instead of your project.

  If you want to keep the HTML file name as it is, you need to update the live site URL to https://stain-i.github.io/Newbie-QR-Code-attempt/indexQR.html.

  You should also upload the QR code image to the repository. Otherwise, <img src="images/image-qr-code.png" alt="QR-code"> will not show any image.

  I recommend using a more modern CSS reset. My recommendation — A Modern CSS Reset | Andy Bell

  I hope this helps. Happy coding! 👍

  1
• 

  Durban86•320

  @Durban86Posted over 1 year ago

  This is a simple project, you don’t need a full reset in your CSS..

  You have some repeating code in the CSS, try refactoring it. For example all the same text styles (font family and line height) put in the body.

  Learn flex box Complete Guide to Flexbox it’s going to help you layout elements easier.

  Also you should use a main tag instead of a section tag in your HTML.

  Probably don’t need the .index in your class names

  As far as naming files, you don’t need the QR in the file names if you have your project organized.

  To create a live version of the code, you need to go into setting of the repository on GitHub, then click pages and deploy it from the main branch

  1