Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Anna 545

@NitaLewska

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I've finally returned to Frontend Mentor, my plan is to complete all Newbies challenges left undone next week and switch to the next level =)

I don't use BEM, but a lot of people here, in Russia, consider it to be the best practice, what do you think? I mean, do I need to try to use it in some of next challenges? =)

Community feedback

Adriano 37,910

@AdrianoEscarabote

Posted

Hi Anna, how are you?

I really liked the result of your project, but I have some tips that I think you will enjoy:

As you know this page is just a component, so it doesn't even need an h1! because we don't know how important the other components of the site will be! but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1. to resolve this, replace h2 with h1.

Wrap all the content with the main tag to inform what the main content of the page is, taking into account that this challenge is just a component, we can wrap all the content!

The rest is great!

I hope it helps... 👍

0

Anna 545

@NitaLewska

Posted

@AdrianoEscarabote

Hi! I think that it's not really necessary to make this all just to pass the test, and it's obvious that it's just a card, so it can't have even an h2 tag - maybe h4 or even just a span. Of course, in a bigger project, it's necessary to have the full and clear structure - header, main, footer, h1 and so on, but is it really necessary when you make just a reusable card component? I've started studying React not so long ago, and i like the idea of reusable components a lot!)

Thanks for your advice anyways =)

1
Adriano 37,910

@AdrianoEscarabote

Posted

@NitaLewska =)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord