QR Code Component

Community feedback

• 

  Mo•130

  @mo-rob-1Posted almost 3 years ago

  Hey! You did a great job on this challenge. Well done.

  After looking at your code, a tip I have is to have a look at the BEM methodology (Block Element Modifier) for naming your classes. This helps to keep your code organized and maintainable E.g. You could have a container div named 'card' and inside that div you can use naming conventions like 'card__img', 'card__desc' etc for the image and text.

  Hope this helps & keep up the good work :)

  Marked as helpful

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Larissa Cauane Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body <main class="container"></main>

  -> Learn more on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  Marked as helpful

  0
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great work overall man. Nicely done

  • One tip i can give your is to wrap your card with main element to avoid accessibility issues.

  0