QR code component

Community feedback

• 

  Tiago Costa Rebelo•180

  @tiagocostarebeloPosted 4 months ago

  Hello @Mohamed-Oday,

  Great job on your submission!

  I have a few suggestions that might help you improve your project:

  • The background color doesn't match the original design. Adjusting this will bring your project closer to the intended look;

  • Try reducing the width of the card slightly. This will help the text wrap correctly and match the design more closely;

  • Understanding Semantic HTML is important, especially for accessibility. For instance, screen readers rely on proper HTML semantics to provide accurate information to visually impaired users. In your code, you used a form element to wrap the card, but there are no input fields or submit buttons inside. This can cause screen readers to misinform users. I recommend reading this link(https://developer.mozilla.org/en-US/docs/Glossary/Semantics) to learn more about why semantic HTML matters.

  • Improve your class naming conventions. This will help you in the future as your projects become more complex. Here's a useful link(https://getbem.com/naming/).

  Keep up the good work!

  Marked as helpful

  0