Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@Mohamed-Oday

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Learned how to center a form, ill try to be more creative next time

What challenges did you encounter, and how did you overcome them?

Centering the form

Community feedback

@tiagocostarebelo

Posted

Hello @Mohamed-Oday,

Great job on your submission!

I have a few suggestions that might help you improve your project:

  • The background color doesn't match the original design. Adjusting this will bring your project closer to the intended look;

  • Try reducing the width of the card slightly. This will help the text wrap correctly and match the design more closely;

  • Understanding Semantic HTML is important, especially for accessibility. For instance, screen readers rely on proper HTML semantics to provide accurate information to visually impaired users. In your code, you used a form element to wrap the card, but there are no input fields or submit buttons inside. This can cause screen readers to misinform users. I recommend reading this link(https://developer.mozilla.org/en-US/docs/Glossary/Semantics) to learn more about why semantic HTML matters.

  • Improve your class naming conventions. This will help you in the future as your projects become more complex. Here's a useful link(https://getbem.com/naming/).

Keep up the good work!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord