Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR Using Html & Css

Nermen 270

@NermenElefky

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Is my code the best practice or there is another better way??

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Hi, Nermen!

I recommend putting the attribution below the card content. The main content should be positioned above the attribution.

Some more suggestions:

  • Remove <p class = "proj-title">. The content of the paragraph is the same content as the content of the card.
  • Use CSS to change the font size. Don't use a heading tag to change the styling of the text.
  • Use a CSS reset whenever you start a new project. This can help you set the styling foundation easily. My recommendation — A Modern CSS Reset

It looks like you are following the design-preview.jpg as the main design file. It is a preview image for the README.md file. You should follow the other design files as a reference when building the project.

I hope this helps. Happy coding!

Marked as helpful

0

Nermen 270

@NermenElefky

Posted

@vanzasetia Thank you for your feedback👌. I have updated my code.

1

@MelvinAguilar

Posted

Hello there 👋. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
  • Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). Swap the <h3> tag with <h1>
  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io
  • There are some unnecessary tags, for example "<p class="proj-title">" should not exist.
  • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📘.

I hope you find it useful! 😄

Happy coding!

Marked as helpful

0

Nermen 270

@NermenElefky

Posted

@MelvinAguilar Thanks for your feedback. The links are very useful😄.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord