Design comparison
Solution retrospective
What I would improve for next attempt:
-
Using CSS variables
-
Better understanding of Flexbox
-
Add Responsivness
Community feedback
- @AbeeujahPosted almost 2 years ago
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML 📄:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>).
Alt text 📷:
Images Should Contain Alt Texts as it Helps Assistive Technologies tell the Value of the Image.
The alt attribute should explain the purpose of the image. Upon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io If you want to learn more about the alt attribute, you can read this Article
Marked as helpful1@maxkdavisPosted over 1 year ago@Abeeujah
Awesome feedback. Appreciate you taking the time to write it up. All great suggestions that I will certainly incorporate in my next project.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord