@MelvinAguilar
Posted
Hello π. Congratulation on successfully completing your first challenge π ! !
I have some recommendations regarding your code that I believe will be of great interest to you.
HTML π:
- Use semantic elements such as
<main>
and<footer>
to improve accessibility and organization of your page.
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose. e.g.QR code to frontendmentor.io
CSS π¨:
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. Source π.
-
Setting a defined
height
for the card component is not recommended (height: 60%;
). The content should define the component height, otherwise, it will not be allowed to extend beyond your specifications. screenshot.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@OluwadaraDaily
Posted
@MelvinAguilar Thank you very much. I'll heed to these advices