Skip to content
Submitted about 2 years ago

QR code component

gabilucuta•220
@gabilucuta
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • romila•3,570
    @romila2003Posted about 2 years ago

    Hi @gabilucuta,

    Congratulations 🎉 for completing this challenge, the card looks great. There are some issues I want to address:

    1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
    2. You should also wrap the footer within the footer tag e.g. <footer class="attribution"></footer>
    3. Your box-shadow is quite strong therefore I would suggest you to use something like this: box-shadow: 10px 10px 10px rgba(0,0,0,0.1);
    4. To use the center the card, you can use the height property and set it to 100vh however I would suggest you to use this property on the body since the body should cover everything e.g.
    body {
  display: flex;
  align-items: center;
  justify-content: center;
  min-height: 100vh;
  flex-direction: column;
}

    I added the flex-direction: column; since you have a footer.

    Overall, great attempt and wish you the best for your future projects so keep coding 👍.

    Marked as helpful
    0
    gabilucuta•220
    @gabilucutaPosted about 2 years ago

    @romila2003 Hi , thank you very much for this reply , I was struggling with the center part . The tips are great !!

    1
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @gabilucuta, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

    1.The value you’ve used for the shadow make it too much dark and strong. To improve your box-shadow, you’ve to have in mind two things that make a good shadow, blur and low opacity for smooth shadows. To improve your current shadow, decrease the opacity and increase the blur, try this value instead: box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%);

    If you’re not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/

    2.Something I've noticed in your code is that in many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    0
    gabilucuta•220
    @gabilucutaPosted about 2 years ago

    @correlucas Hi , thank you for this reply , it helps me alot . Im kinda newbie in html and css and trying my best to get the job done !!

    1
    Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    @gabilucuta I'm happy to hear that was useful for you Gabil! Keep it up

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord