Skip to content
Submitted about 2 years ago

QR Code Component

shalash23•280
@shalash23
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

If anyone can comment on the mistakes that had been made, I would really appreciate it.

Are the media queries correct?

Is it responsive on all different devices?

Community feedback

  • Adriano•38,330
    @AdrianoEscarabotePosted about 2 years ago

    Hi shalash23, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Document should have one main landmark, you could have put all the content inside the main tag click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    0
    shalash23•280
    @shalash23Posted about 2 years ago

    @AdrianoEscarabote Thanks for the articles, I would surely follow those in the next challenge

    1
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi @shalash23, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

    1,Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

    2.Add the alt text to improve the accessibility.The alt attribute provides alternative information for an image if a user for some reason cannot view it (because of slow connection, an error in the src attribute, or if the user uses a screen reader). ---> <img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor">

    3.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    shalash23•280
    @shalash23Posted about 2 years ago

    @correlucas Will do for sure in the next challenge :)

    1
  • Vincent Daniel•410
    @davinceeyPosted about 2 years ago

    Hello shalash23. Congratulations on your first project! Some little tips for you:

    1. You might want to wrap all your content in a <main> semantic tag. You could also make use of <section> and/or <article> semantic tags. This would help to improve Accessibility.

    2. Your images, should have alternative texts as well alt ="".

    Hope this helps you. Happy Coding!💖

    Marked as helpful
    0
    shalash23•280
    @shalash23Posted about 2 years ago

    @davinceey I will give sematic tags a try in my next challenge.

    1
    Vincent Daniel•410
    @davinceeyPosted about 2 years ago

    @shalash23 Glad to help. Happy Coding!✌️

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord