Qr Code Component

Community feedback

• 

  Martina•150

  @PastoreMartinaPosted over 1 year ago

  Congratulations on completing the challenge!! 🎉

  Something I noticed:

  When declaring a font-family, you should always provide a fallback option in case the user's browser doesn't support what you provided. You can list as many options as you want, divided by a comma.

  Ex: font-family: 'Outfit', sans-serif;

  More about it here.

  I hope my comment was helpful 😁

  Above all, good job 💪🏻

  Marked as helpful

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="card"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Replace the width in the img with max-width for a responsive image.

  Give h1 and p the same font-size of 15px which is 0.9375rem, text-align: center,the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0