Travolgi 🍕• 31,420
@denielden
Posted
Hi Luyanda, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
maintag and wrap the card for Accessibility - remove all
marginfrom.white-cardclass - try to use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-height: 100vhto body because Flexbox aligns child items to the size of the parent container
Overall you did well 😉
Hope this help and happy coding!
1
Luyanda• 40
@lmaqungo
Posted
@denielden Thanks for the feedback. I'm off to learning flexbox now. What did you mean by 'add main tag and wrap the card for Accessibility'?
1
Travolgi 🍕• 31,420
@denielden
Posted
@lmaqungo You are welcome! For main tag read here
1
