QR code component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Luyanda, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • remove all margin from .white-card class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well 😉

  Hope this help and happy coding!

  1

  ---

  

  Luyanda•40

  @lmaqungoPosted over 2 years ago

  @denielden Thanks for the feedback. I'm off to learning flexbox now. What did you mean by 'add main tag and wrap the card for Accessibility'?

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @lmaqungo You are welcome! For main tag read here

  1