QR Code Component

Community feedback

• 

  Hassia Issah•50,670

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag, <p class="qr_code_intro"><strong> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

  Give the max-width of .container a fixed value instead of a percentage value and a fixed padding value all the sides. e.g. .container{max-width: 320px; padding: 20px;}

  Give the margins , paddings and border-radius fixed values instead of percentage values. Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

  There is no need to give the img position: grid and place-items: center.

  To center .container on the using grid, add align-content: center and min-height:100vh to the body and remove the margin value from the body. Or you remove justify-content: center; and add place-items: center and min-height:100vh.

  Hope am helpful HAPPY CODING

  0